Skip to content

Conversation

@kunicmarko20
Copy link
Contributor

Was reviewing the dsn class since I plan to use it and I saw some commented code. If this was intentional just close the PR.

Looks like a nice lib, thank you!

@makasim
Copy link
Member

makasim commented Nov 28, 2018

@kunicmarko20 you are right, those methods should be removed.

@makasim makasim merged commit 60674f7 into php-enqueue:master Nov 28, 2018
@makasim makasim changed the title Dead code? [dsn] remove commented out code Nov 28, 2018
@kunicmarko20 kunicmarko20 deleted the patch-1 branch November 29, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants